Introduce TMath::KNNDensity and deprecate TH1K
#19765
Open
+151
−140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferdymercury
suggested changes
Aug 27, 2025
Test Results 20 files 20 suites 3d 21h 36m 21s ⏱️ For more details on these failures, see this check. Results for commit 0065e65. ♻️ This comment has been updated with latest results. |
ferdymercury
approved these changes
Aug 27, 2025
guitargeek
force-pushed
the
th1k
branch
2 times, most recently
from
242c855 to
0065e65
Compare
dpiparo
approved these changes
Aug 29, 2025
ferdymercury
suggested changes
Sep 2, 2025
The `TH1K` class is deprecated and will be removed in 6.40. It did not implement the `TH1` interface consistently, and limited the usability of the k-neighbors method it implemented by closely coupling the algorithm with the histogram class. Instead, one should use the new `TMath::KNNDensity` function that implements the same mathematical logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TH1Kclass is deprecated and will be removed in 6.40. It did not implement theTH1interface consistently, and limited the usability of the k-neighbors method it implemented by closely coupling the algorithm with the histogram class. Instead, one should use the newTMath::KNNDensityfunction that implements the same mathematical logic.Closes #19761 and https://its.cern.ch/jira/browse/ROOT-5686.
TODO: