Skip to content

[hist] fix unwanted and biased background plotting with negative Z content of TScatter #20437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+3 −2
Open

[hist] fix unwanted and biased background plotting with negative Z content of TScatter #20437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e0f82a
[nfc] fix typo in docu
ferdymercury Nov 15, 2025
1e040cd
[hist] use same n contours for background histogram
ferdymercury Nov 15, 2025
c58fd46
[hist] avoid h empty bins to be drawn as background if negative Z val…
ferdymercury Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hist/hist/src/TScatter.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ TH2F *TScatter::GetHistogram() const
{
if (!fHistogram) {
// do not add the histogram to gDirectory
// use local TDirectory::TContect that will set temporarly gDirectory to a nullptr and
// use local TDirectory::TContext that will set temporarly gDirectory to a nullptr and
// will avoid that histogram is added in the global directory
TDirectory::TContext ctx(nullptr);
double rwxmin, rwymin, rwxmax, rwymax;
Expand Down
3 changes: 2 additions & 1 deletion hist/histpainter/src/TGraphPainter.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4474,8 +4474,9 @@ void TGraphPainter::PaintScatter(TScatter *theScatter, Option_t* chopt)
}

TH2F *h = theScatter->GetHistogram();
h->SetContour(gStyle->GetNumberOfColors()); // Ensure same number of divisions in underlying hist than in TScatter palette
if (optionAxis) {
h->Paint(" ");
h->Paint("COL1"); // avoid h empty bins to be drawn as background if negative Z values in scatter plot
if (h->GetMinimum() < h->GetMaximum()) {
if (minc<h->GetMinimum()) minc = h->GetMinimum();
if (maxc>h->GetMaximum()) maxc = h->GetMaximum();
Expand Down
Loading