[v638][RF] Backport recent RooFit bugfixes #20444
Merged
+65
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 95fe1d8)
Since a8ef8b0, any RooAbsPdf that makes a prediction for the expected number of events will use this prediction for the normalization when plotting. This made is more meaningful to compare models with data because the model normalization was not automatically scaled to match the data. However, it also broke plots with projections of RooSimultaneous pdfs over data, because the temporary RooAddPdf that is created in this case did not use coefficients that were scaled to the actual dataset, but to unity. Correctly normalizing to the sum of entries in the dataset fixes this problem. A unit test is also implemented. Closes root-project#20383. (cherry picked from commit 61735d8)
Avoid warning about duplicate command arguments by removing old arguments when overriding them. (cherry picked from commit d4b150c)
Just like in any other getter for the inputs of RooFit functions, the `RooPolyVar::x()` getter should return the underlying RooAbsReal, instead of the internal proxy. Closes root-project#20293. (cherry picked from commit 66cd6ae)
guitargeek
changed the title
Test Results 22 files 22 suites 3d 20h 50m 6s ⏱️ For more details on these failures, see this check. Results for commit 8c5b1ff. |
guitargeek
merged commit f1e7d46
into
root-project:v6-38-00-patches
26 of 30 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport some fixes for RooFit to the release branch.