[RF] Avoid resetting the workspace of ModelConfig in HistFactory #20445
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-setting the workspace can be dangerous for IO reasons, and this is why the new ROOT now emits a warning when this happens. There is one place in HistFactory that triggered this warning, where the Workspace was redundantly set in the constructor and with the `ModelConfig::SetWorkspace()` function, with the same workspace.
lmoneta
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-setting the workspace can be dangerous for IO reasons, and this is why the new ROOT now emits a warning when this happens.
There is one place in HistFactory that triggered this warning, where the Workspace was redundantly set in the constructor and with the
ModelConfig::SetWorkspace()function, with the same workspace.See also:
Klass::contains->Klass.__contains__pythonization and use it in RooFit #19999