Review GitHub Pull Request for Missing Elements #1200
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements the rootless user functionality for both production and development Docker images with all improvements from PR #837 review: Changes made: - Added rootless user setup using 'rails' username (not 'rails_api_base') - Used ARG instead of ENV for USERNAME, USER_UID, and USER_GID build variables - Set proper file ownership and permissions (700) for security - Added explanatory comment for temporary root switch in jemalloc symlink creation - Applied --chown and --chmod flags to all COPY operations Security improvements: - Application now runs as non-root user (UID/GID 1000) - Reduced attack surface by limiting privileges - Follows Docker security best practices Files modified: - Dockerfile: Added rootless user for production image - Dockerfile.dev: Added rootless user for development image 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements the rootless user functionality for both production and development Docker images with all improvements from PR #837 review:
Changes made:
Security improvements:
Files modified:
🤖 Generated with Claude Code
Board:
Description:
Notes:
Tasks:
Risk:
Preview: