Skip to content

Conversation

@snovvcrash
Copy link

Hi @ropnop!

In this PR I would like to bring a fix for the --resolve switch. Currently using the resolve IP feature breaks the script due to a type error:

$ python3 windapsearch.py --dc-ip 127.0.0.1 -d corp.local -u '' -C -r > windapsearch.out
Traceback (most recent call last):
  File "/home/snovvcrash/tools/windapsearch/windapsearch.py", line 825, in <module>
    run(args)
  File "/home/snovvcrash/tools/windapsearch/windapsearch.py", line 610, in run
    allComputersDict = ldapSession.getComputerDict(allComputers, ipLookup=True)
  File "/home/snovvcrash/tools/windapsearch/windapsearch.py", line 380, in getComputerDict
    computerInfo[attr] = ','.join(computer.get_attr_values(attr))
TypeError: sequence item 0: expected str instance, bytes found

The ipLookup argument in getComputerDict does not seem to be used as well, but I left it as is.

Also I've added a cyrillic name for Domain Admins group in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant