Skip to content

Conversation

christophfroehlich
Copy link
Contributor

@pedroazeredo04 was there a reason why we added the specialization of the update method, if it has the exact same code as the templated one? I don't see it..

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.02%. Comparing base (20f9ea3) to head (8f2963a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #509      +/-   ##
==========================================
+ Coverage   82.61%   83.02%   +0.41%     
==========================================
  Files          29       29              
  Lines        1984     1968      -16     
  Branches      113      110       -3     
==========================================
- Hits         1639     1634       -5     
+ Misses        276      268       -8     
+ Partials       69       66       -3     
Flag Coverage Δ
unittests 83.02% <ø> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...oolbox/include/control_filters/low_pass_filter.hpp 65.00% <ø> (+15.00%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pedroazeredo04
Copy link
Contributor

@pedroazeredo04 was there a reason why we added the specialization of the update method, if it has the exact same code as the templated one? I don't see it..

I don't see it also, it really seems like it was just redundant code that we overlooked

@christophfroehlich
Copy link
Contributor Author

@pedroazeredo04 Thanks, could you hit the approval button please :)

@christophfroehlich christophfroehlich merged commit f5a3f2f into master Oct 22, 2025
15 of 16 checks passed
@christophfroehlich christophfroehlich deleted the remove/overloads branch October 22, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants