Reuse the logger with get_logger method #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eholum-nasa
approved these changes
Dec 15, 2025
Collaborator
eholum-nasa
left a comment
eholum-nasa
left a comment
There was a problem hiding this comment.
Good learnings for me here... though should we be using node logging in the system interface once the node is available? Doesn't seem like there's a significant difference.
| mjvPerturb pert_; | ||
|
|
||
| // Logger | ||
| rclcpp::Logger logger_ = rclcpp::get_logger("MujocoSystemInterface"); |
Collaborator
There was a problem hiding this comment.
Oh I did not realize this got constructed every time! Nice change!
Member
Author
As it is a simulation, this is fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just consolidates all get_logger calls with a single one that returns the member variable