-
Notifications
You must be signed in to change notification settings - Fork 9
Support torque and force command and state interfaces #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support torque and force command and state interfaces #29
Conversation
eholum-nasa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Is the difference for say, prismatic vs revolute joints?
The only other comment I have, because of the question on the test robot, is that it's probably worth updating the README to show that effort/force/torque interfaces are supported, but that the differences are exclusively semantic... We could also just add a note?
**Note:** The `torque` and `force` command/state interfaces are semantically equivalent to `effort`, and map to the same underlying data in the sim.
Co-authored-by: Erik Holum <erik.holum@nasa.gov>
Co-authored-by: Erik Holum <erik.holum@nasa.gov>
eholum-nasa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
This PR add changes that are needed to support torque and force command and state interfaces. Basically, it remaps to the effort part of the interface.