Add support to game_controller_node for sending separate intensities to left and right rumble motors.#299
Open
marcmarmir wants to merge 1 commit intoros-drivers:ros2from
Conversation
marcmarmir
force-pushed
the
add_left_right_game_controller_rumble_channels
branch
from
4472d7d to
83ea838
Compare
marcmarmir
force-pushed
the
add_left_right_game_controller_rumble_channels
branch
from
83ea838 to
b9a763e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#298
Add support to
game_controller_nodefor sending rumble effects to left and right rumble motors individually.idfield inJoyFeedbackmessage now specifies which motor to rumble:id: 0both motors (matches current behaviour)id: 1left (LF) motorid: 2right (HF) motorintensity_left_stamped_andintensity_right_stamped_store the value and timestamp of the most recent rumble command on that motor. Calls toSDL_GameControllerRumble()set rumble intensity values for both motors. Now, if a callback is triggered for a left-only or right-only rumble message, the node checks whether the other motor should still be rumbling. If so, it re-uses its previous intensity value, and otherwise sets its intensity to0.