[WIP] SDL2 on macOS detects joysticks only with SDL2_INIT_VIDEO#302
Open
EliaCereda wants to merge 1 commit intoros-drivers:ros2from
Open
[WIP] SDL2 on macOS detects joysticks only with SDL2_INIT_VIDEO#302EliaCereda wants to merge 1 commit intoros-drivers:ros2from
EliaCereda wants to merge 1 commit intoros-drivers:ros2from
Conversation
Contributor
|
This PR seems to contain a lot of unrelated changes. Or are they related? I think this workaround has to be enabled by a parameter (that defaults to false). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDL2 on macOS seems to have issues detecting joysticks that are already connected at startup (I started a discussion here: libsdl-org/SDL#12886).
I'm opening a PR to share this workaround that seems to make everything work correctly, but it's not a proper fix right now. I'm sure initialising SDL2_INIT_VIDEO is not very desirable, especially not on other platforms, as it prevents the joy node from running headless.
Was this a known issue?