fix node args used to launch joy nodes via launch file

[andreas-loeffler]

FIX

• closing joy-launch.py does not work #306

This PR is fixing the usage of the ComposableNode and Node arguments to work under ros2 jazzy and rolling, by removing the outdated node_ prefix for the class arguments

[peci1]

Thanks for the fix. I really wonder where does the previous syntax come from... Even Humble does not seem to be using it. So I think merging this fix is safe if we consider that ros2 branch should work on all supported distros, which is currently Humble, Jazzy, Kilted and Rolling.

One thing I'd like to sneak in in this PR: would you please also change this line

joystick_drivers/joy/config/joy-params.yaml

Line 4 in 881f3a5

device_name: "''"

to read device_name: ""? Otherwise, the launch files are useless...

[peci1]

Anyways, I'd like to switch to XML launch files and deprecate the Python ones, but that's for a different PR...

[andreas-loeffler]

Thanks for the fix. I really wonder where does the previous syntax come from... Even Humble does not seem to be using it. So I think merging this fix is safe if we consider that ros2 branch should work on all supported distros, which is currently Humble, Jazzy, Kilted and Rolling.

One thing I'd like to sneak in in this PR: would you please also change this line

joystick_drivers/joy/config/joy-params.yaml

Line 4 in 881f3a5

device_name: "''"

to read device_name: ""? Otherwise, the launch files are useless...

fixed in c3e4944

I think the "node_" prefix was an artifact from dashing/eloquent, its deprecated since foxy haha

[andreas-loeffler]

Anyways, I'd like to switch to XML launch files and deprecate the Python ones, but that's for a different PR...

lmk if u want me to open an issue regarding that. I'd be happy to take a look at that!

[peci1]

lmk if u want me to open an issue regarding that. I'd be happy to take a look at that!

Please do! Thanks ;)