Reorder commands (toward Gitlab compatibility)#483
Merged
nuclearsandwich merged 2 commits intoros-infrastructure:masterfrom Sep 14, 2018
Merged
Reorder commands (toward Gitlab compatibility)#483nuclearsandwich merged 2 commits intoros-infrastructure:masterfrom
nuclearsandwich merged 2 commits intoros-infrastructure:masterfrom
Conversation
DLu
force-pushed
the
feature/gitlab_prepull_0
branch
from
361a42b to
795cf21
Compare
Contributor
Author
|
(the diff is much clearer with whitespace changes turned off) |
Contributor
Author
|
Ping @nuclearsandwich |
Contributor
|
No whitespace link for other reviewers https://github.com/ros-infrastructure/bloom/pull/483/files?w=1 I am waiting on merging this to test the changes on an actual release. But I am generally positive about the change. |
nuclearsandwich
approved these changes
Sep 14, 2018
Contributor
nuclearsandwich
left a comment
nuclearsandwich
left a comment
There was a problem hiding this comment.
Tested locally and it works on python 2 and doesn't change the failure mode in python 3.
Contributor
|
Thanks for the continued work and for breaking things into review-able chunks. |
DLu
referenced
this pull request
in locusrobotics/bloom
Sep 29, 2018
* Reorder commands * Fix overly long line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to make #458 easier to merge, I've made this branch which just reorders some of the core commands such that
if Trueblock, so that future whitespace changes are not needed.Let me know if this helps @nuclearsandwich