Split the --new-track and --edit-track options#545
Draft
clalancette wants to merge 2 commits intomasterfrom
Draft
Split the --new-track and --edit-track options#545clalancette wants to merge 2 commits intomasterfrom
clalancette wants to merge 2 commits intomasterfrom
Conversation
While both edit-track and new-track use the exact same code in the backend, they are conceptually different. Split up argument help so that they are different. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While using
bloom-release, I noticed that--new-trackand--edit-trackwere in the same help bullet. They both use exactly the same code path, so from an implementation point of view, that makes some sense. However, they are conceptually different things, so I think splitting the help makes sense. That's what commit e3beb88 .Commit 34c07a1 starts to go further and make them actually different actions. It doesn't quite work yet, but I was shooting for the following behavior:
--new-trackand--edit-trackare mutually exclusive options--new-trackis specified, and the track already exists, an error is thrown.--edit-trackis specified, and the track does not exist, an error is thrown.However, there are a lot of use-cases here, so I'm not sure if that logic is what we are going for. I'm opening this as a draft until then to get some feedback and see what others think of this.