Generate -runtime packages with --runtime-pkg#703
Open
jspricke wants to merge 2 commits intoros-infrastructure:masterfrom
Open
Generate -runtime packages with --runtime-pkg#703jspricke wants to merge 2 commits intoros-infrastructure:masterfrom
jspricke wants to merge 2 commits intoros-infrastructure:masterfrom
Conversation
33f32f3 to
603d9f6
Compare
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/package-separation-for-building-and-running-ros-applications/35527/5 |
peci1
reviewed
Jan 9, 2024
603d9f6 to
1e9f455
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows separating runtime and development packages to cut the dependency
tree. Note that all packages would need to be created with the --runtime-pkg
option as there is no logic to store which packages has one and which one does
not. Dependencies are separated by exec_depend/build_export_depend.
The package split currently only moves the include directory as the cmake,
pkg-confg and package.xml files could be used by runtime scripts.
Also the package names are -runtime/ instead of /-dev so users get everything
in case they install the old package name.
In case you want to use this on packages.ros.org I would recommend to run
bloom-generate as part of the package build process.
The second patch adds a similar logic for test dependencies by using
test_depend only for runtime packages. Test dependencies that need development
files would need to use build_depend. This is a light redefinition of the tag
but allows to cut the dependency tree even further.