Fixed Inappropriate Logic: Removed logical short circuit#711
Closed
nydelzaf wants to merge 1 commit intoros-infrastructure:masterfrom
Closed
Fixed Inappropriate Logic: Removed logical short circuit#711nydelzaf wants to merge 1 commit intoros-infrastructure:masterfrom
nydelzaf wants to merge 1 commit intoros-infrastructure:masterfrom
Conversation
Signed-off-by: fazledyn-or <ataf@openrefactory.com>
Contributor
|
The description seems to pretty inadequately describe the problem. If this is a "short circuit" I don't see how since what it looks like to me is a condition that could never be and is thus, extraneous. However the condition that seems like it's intended to be checked: Closing in favor of #746. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
While triaging your project, our bug fixing tool generated the following message(s)-
Changes
CLA Requirements
This section is only relevant if your project requires contributors to sign a Contributor License Agreement (CLA) for external contributions.
All contributed commits are already automatically signed off.
Sponsorship and Support
This work is done by the security researchers from OpenRefactory and is supported by the Open Source Security Foundation (OpenSSF): Project Alpha-Omega. Alpha-Omega is a project partnering with open source software project maintainers to systematically find new, as-yet-undiscovered vulnerabilities in open source code - and get them fixed – to improve global software supply chain security.
The bug is found by running the Intelligent Code Repair (iCR) tool by OpenRefactory and then manually triaging the results.