Skip to content

Fixed Inappropriate Logic: Removed logical short circuit#711

Closed
nydelzaf wants to merge 1 commit intoros-infrastructure:masterfrom
nydelzaf:Fix_Inappropriate_Logic
Closed

Fixed Inappropriate Logic: Removed logical short circuit#711
nydelzaf wants to merge 1 commit intoros-infrastructure:masterfrom
nydelzaf:Fix_Inappropriate_Logic

Conversation

@nydelzaf
Copy link

Details

While triaging your project, our bug fixing tool generated the following message(s)-

In file: config.py, the comparison of Collection length creates a logical short circuit. iCR suggested that the Collection length comparison should be done without creating a logical short circuit.

Changes

  • Removed a comparison that compares lenghth of a list with less than zero

CLA Requirements

This section is only relevant if your project requires contributors to sign a Contributor License Agreement (CLA) for external contributions.

All contributed commits are already automatically signed off.

The meaning of a signoff depends on the project, but it typically certifies that committer has the rights to submit this work under the same license and agrees to a Developer Certificate of Origin (see https://developercertificate.org/ for more information).
- Git Commit SignOff documentation

Sponsorship and Support

This work is done by the security researchers from OpenRefactory and is supported by the Open Source Security Foundation (OpenSSF): Project Alpha-Omega. Alpha-Omega is a project partnering with open source software project maintainers to systematically find new, as-yet-undiscovered vulnerabilities in open source code - and get them fixed – to improve global software supply chain security.

The bug is found by running the Intelligent Code Repair (iCR) tool by OpenRefactory and then manually triaging the results.

Signed-off-by: fazledyn-or <ataf@openrefactory.com>
@nuclearsandwich
Copy link
Contributor

The description seems to pretty inadequately describe the problem. If this is a "short circuit" I don't see how since what it looks like to me is a condition that could never be and is thus, extraneous. However the condition that seems like it's intended to be checked: len(remotes) == 0 would be more appropriate, however it seems like changing this today introduces test errors.

Closing in favor of #746.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants