Skip to content

Conversation

@furushchev
Copy link
Contributor

The boost::filesystem::path::append function defined in the src/nodelet/face_recognition_nodelet.cpp have conflict with the boost function.
In this PR, I removed the function and expanded the content to the only called place (in the user_expanded_path function).

In addition to that, I fixed the cmake warning:

Warnings   << opencv_apps:cmake /var/runner/catkin_ws/logs/opencv_apps/build.cmake.000.log                                                                                                             
CMake Warning (dev) in CMakeLists.txt:
  A logical block opening on the line

    /var/runner/catkin_ws/src/opencv_apps/CMakeLists.txt:5 (if)

  closes on the line

    /var/runner/catkin_ws/src/opencv_apps/CMakeLists.txt:16 (endif)

  with mis-matching arguments.
This warning is for project developers.  Use -Wno-dev to suppress it.

@furushchev
Copy link
Contributor Author

I successfully built the package on Ubuntu 20.04 / Noetic and Ubuntu 24.04 / One while the CI failed...

@furushchev
Copy link
Contributor Author

@k-okada Hello! I'm wondering what is the current situation of the maintenance in this repository.
Am I opening the pull request in the right place? Or should I request to copy the repository under the ros-o organization for creating this kind of pull request? Thank you in advance!

k-okada added a commit to k-okada/opencv_apps that referenced this pull request Feb 15, 2025
@k-okada k-okada mentioned this pull request Feb 15, 2025
Copy link
Contributor

@k-okada k-okada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you!!!
I have merged with patches to fixed CI and add ROS-O noble test #147

@furushchev
Copy link
Contributor Author

@k-okada Thank you for your quick merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants