Skip to content

Conversation

@sdmcgrath
Copy link
Contributor

Signed-off-by: Sean McGrath seanmcgrath@intrinsic.ai

Signed-off-by: Sean McGrath <seanmcgrath@intrinsic.ai>

Signed-off-by: Sean McGrath <seandavidmcgrath77@gmail.com>
@sdmcgrath sdmcgrath force-pushed the pkgconfig_relocatable branch from 103bb54 to 1f6f862 Compare November 20, 2024 00:22
@sdmcgrath
Copy link
Contributor Author

Related to ros2/ros2#606
Applies the same patch as in ros2/urdfdom#20 making the exported pkgconfig .pc files relocatable.
This closes #79

@ahcorde
Copy link
Contributor

ahcorde commented Nov 20, 2024

we need to update this package too https://github.com/ros2/console_bridge_vendor . Do you mind to open a PR ?

@sdmcgrath
Copy link
Contributor Author

we need to update this package too https://github.com/ros2/console_bridge_vendor
@ahcorde Sorry, as console_bridge_vendor doesn't currently have a package-config file, could you clarify what update you are suggesting? Thanks!

@ahcorde ahcorde merged commit 122ed72 into ros:master Dec 17, 2024
3 checks passed
@sdmcgrath sdmcgrath deleted the pkgconfig_relocatable branch December 17, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants