Ignore unused parameter in FilterBase::reconfigureCB() #87
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@jonbinney could you take a look? I'd like to get this merged and then get a new Humble release to fix some Hbin regressions. |
jonbinney
requested changes
May 14, 2025
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
christophebedard
force-pushed
the
christophebedard/fix-unused-param
branch
from
1730409 to
3579c6d
Compare
jonbinney
approved these changes
May 14, 2025
Contributor
|
This will need a release now to fix the build farm problems, right? |
Member
Author
|
Yes, that would be very much appreciated! Specifically for Humble, but I'm assuming you want to create releases for all distros at once/one after the other. |
Contributor
|
Releases of 2.2.1 done for humble, jazzy, and rolling |
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/preparing-for-humble-sync-2025-05-16/43770/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #83.
parametersis unused, which results in a build error/failure when this warning is treated as an error. For example, this package binary build is failing: https://build.ros2.org/view/Hbin_uJ64/job/Hbin_uJ64__grid_map_cv__ubuntu_jammy_amd64__binary/55/console