Skip to content

Fix path regex substitution#375

Closed
Noel215 wants to merge 1 commit intoros:ros2from
Noel215:fix/path_regex_substitution
Closed

Fix path regex substitution#375
Noel215 wants to merge 1 commit intoros:ros2from
Noel215:fix/path_regex_substitution

Conversation

@Noel215
Copy link
Contributor

@Noel215 Noel215 commented Aug 28, 2025

Hi,

This commit broke the method process_file when the input_file_name argument if of type pathlib.Path instead of os.path (string).

This PR fixes that issue, adding a test for compatibility with both path types

Already reported in the following issues:

@acalhoon
Copy link

Thanks for the quick patch and for creating the PR for me!

@rhaschke
Copy link
Contributor

Thanks for the PR. Merged via 3d061ea and 46cb051.

@rhaschke rhaschke closed this Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants