Use RMW Quality of Service profile definitions #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoffmann-stefan
force-pushed
the
upstream_pr2_qos
branch
2 times, most recently
from
984a48b to
4294479
Compare
Contributor
|
Quite interesting that altering the commits to that level is possible without affecting the authorship details! I'm happy with the result 👍 |
hoffmann-stefan
force-pushed
the
upstream_pr2_qos
branch
from
f2387bf to
125e979
Compare
5 tasks
Member
Author
Well, unless you sign your commits with gpg there is no way to enforce this in a distributed vcs. There are git commands/options to manipulate the author of a commit. (e.g. https://stackoverflow.com/a/3042512) |
hoffmann-stefan
commented
Jul 29, 2024
Member
Author
hoffmann-stefan
left a comment
hoffmann-stefan
left a comment
There was a problem hiding this comment.
@Chootin: Looks good, even though I can't technically approve my PR, the changes are from you :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original work from #127 @Chootin
Was playing around with lazygit and wanted to try to split some commits for better history. Did take #127 as playground ;)
@Chootin Hope you are OK with this?
The rest of the PR is in this branch https://github.com/hoffmann-stefan/ros2_dotnet/pull/new/upstream_pr2_params_rebased to avoid having to fix the merge commits when rebasing again. This could be force-pushed onto #127 after this is merged to review further.