Added case for instances of ExecuteLocal in resolveProcess function#587
Merged
adityapande-1995 merged 2 commits intoros2:masterfrom Feb 22, 2022
Merged
Added case for instances of ExecuteLocal in resolveProcess function#587adityapande-1995 merged 2 commits intoros2:masterfrom
adityapande-1995 merged 2 commits intoros2:masterfrom
Conversation
Distro A, OPSEC #4584. You may have additional rights; please see https://rosmilitary.org/faq/?category=ros-2-license Signed-off-by: matthew.lanting <mlanting@dcscorp.com>
Contributor
Author
|
@adityapande-1995 friendly ping |
Contributor
|
CI :
The failing test seems unrelated to the changes made here. |
Contributor
adityapande-1995
left a comment
adityapande-1995
left a comment
There was a problem hiding this comment.
Could you please add a test case for this feature ?
Added case for handling ExecuteLocal actions in _proc_to_name_and_args in proc_lookup.py. Distro A, OPSEC #4584. You may have additional rights; please see https://rosmilitary.org/faq/?category=ros-2-license Signed-off-by: matthew.lanting <mlanting@dcscorp.com>
Contributor
Author
|
Test cases added. I also had to modify a function in proc_lookup to handle both ExecuteProcess and ExecuteLocal objects. |
Contributor
adityapande-1995
left a comment
adityapande-1995
left a comment
There was a problem hiding this comment.
CI rerun:
- Linux
- Linux-aarch64
- Windows
adityapande-1995
approved these changes
Feb 22, 2022
Contributor
adityapande-1995
left a comment
adityapande-1995
left a comment
There was a problem hiding this comment.
LGTM, unless @jacobperron disagrees.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The resolveProcess function needs to allow cases where the process is launched via instances of ExecuteLocal. This will likely be revisited when ExecuteRemote is added since we'll probably want to generalize the base class, but for now this should let the tests for ros2/launch_ros#215 pass so it can finally get merged.