[dashing] Fix rcl_action test_graph (#504)#874
Merged
jacobperron merged 2 commits intodashingfrom Feb 18, 2021
Merged
Conversation
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
ivanpauno
approved these changes
Jan 29, 2021
Member
ivanpauno
left a comment
ivanpauno
left a comment
There was a problem hiding this comment.
LGTM, this seems to be only worth merging if it solves the linked CI failures
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Member
Author
|
I had to update the expected error codes, since they are different in Dashing compared to newer distros (9efb722) |
ivanpauno
approved these changes
Feb 17, 2021
Member
Author
|
@ros-pull-request-builder retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #504 to Dashing.
I hoping this will clear up some similar test failures occurring in Dashing, e.g.: