Conversation
…on to errorProcessing Signed-off-by: thebyohazard <patrick@jlpengineering.com>
thebyohazard
force-pushed
the
lifecycle_primary_state_error_transitions
branch
from
53b549b to
3cc8bdf
Compare
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
This needs to rebase and add description for each method.
| const State & | ||
| LifecycleNode::raise_error() | ||
| { | ||
| if(get_current_state().id() == lifecycle_msgs::msg::State::PRIMARY_STATE_ACTIVE) |
There was a problem hiding this comment.
I do not think this needs to be checked here. it will check the current state and get the reference to rcl_lifecycle_transition_t in rcl state_machine.
| { | ||
| if(get_current_state().id() == lifecycle_msgs::msg::State::PRIMARY_STATE_ACTIVE) | ||
| return impl_->trigger_transition( | ||
| lifecycle_msgs::msg::Transition::TRANSITION_ACTIVE_ERROR); |
There was a problem hiding this comment.
| lifecycle_msgs::msg::Transition::TRANSITION_ACTIVE_ERROR); | |
| rcl_lifecycle_error_label); |
|
What is the state of this PR? |
|
Will this PR be ever merged? |
|
I think we still need to work on design at 1st, but i don't think i can be working on this in soon. |
|
Given that this PR is so old, and that we need a design fix first, I'm going to close it out. If you are planning on working on it, please push forward on the design update first, then we can open a new PR with changes that implement that design. Thanks for the contribution. |
6 participants
This PR (built on top of required PRs ros2/rcl_interfaces#97 and ros2/rcl#618) provides convenience functions for lifecycle nodes to self-trigger the error transitions created in the previous PRs.
This also addresses issue #547