Skip to content

Lazily import C extensions#422

Closed
ivanpauno wants to merge 2 commits intomasterfrom
ivanpauno/add_functions_for_getting_c_extensions
Closed

Lazily import C extensions#422
ivanpauno wants to merge 2 commits intomasterfrom
ivanpauno/add_functions_for_getting_c_extensions

Conversation

@ivanpauno
Copy link
Member

Yet another alternative to #417 #420.
See #420 (comment).

I ended up having a lot of problems with the qos module after applying lazy import, as all the default profiles are constructed at module level.
For working around the problem, I did a lot of changes that I don't like at all.

I would rather solve ros2/build_farmer#235 directly in launch_testing_ros, and figure out later how to avoid having to "hack" the imports while testing in rclpy (which is the root cause of ros2/build_farmer#235).

I would rather not merge this PR nor apply lazy import in general, as I believe is creating more problems than solving.

Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added the in review Waiting for review (Kanban column) label Sep 11, 2019
@ivanpauno ivanpauno self-assigned this Sep 11, 2019
@ivanpauno
Copy link
Member Author

ivanpauno commented Sep 11, 2019

This is the launch_testing_ros patch that @hidmic sent:
ros2/launch_ros#69

@ivanpauno
Copy link
Member Author

Closing, because this is outdated.
We should still investigate ways of solving this issue.

@ivanpauno ivanpauno closed this May 22, 2020
@dirk-thomas
Copy link
Member

We should still investigate ways of solving this issue.

@ivanpauno Is there any open ticket for this? If not, please create one and reference the previous approaches.

Also is the branch still needed?

@ivanpauno ivanpauno deleted the ivanpauno/add_functions_for_getting_c_extensions branch May 26, 2020 12:29
@ivanpauno
Copy link
Member Author

@ivanpauno Is there any open ticket for this? If not, please create one and reference the previous approaches.

See #560.

Also is the branch still needed?

I deleted the branch on one of the PRs, and forgot to do ot in the others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in review Waiting for review (Kanban column)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants