fix dead link for launch architecture. #6043
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
commented
Nov 22, 2025
Collaborator
Author
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
@ahcorde can you approve and merge this?
backports are required to all downstream distro.
|
HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/19594918979/artifacts/4648667122. To view the resulting site:
|
Contributor
|
I think the link is currently already as intended, but the launch docs are not published as they once were. I found an existing sphinx project with manual build scripts in launch, maybe this is a pre-rosdoc2 artifact? I think we should rather fix it in launch, i made a corresponding PR here: ros2/launch#930 |
Collaborator
Author
|
closing in favor of ros2/launch#930, architecture doc should be on top structure as it intended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6042
Did you use Generative AI?
No,
Additional Information