Skip to content

Remove importlib packages (backport #1117) #1119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ahcorde merged 3 commits into from
Dec 9, 2025
Merged

Remove importlib packages (backport #1117) #1119

ahcorde merged 3 commits into from
Dec 9, 2025

Conversation

@mergify
Copy link

@mergify mergify bot commented Nov 27, 2025

Description

Fixes # (issue)

Removes importlib packages

Did you use Generative AI?

Additional Information

This is an automatic backport of pull request #1117 done by [Mergify](https://mergify.com).

@InvincibleRMC @mergify
Remove importlib packages (#1117)
9e287cc 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
(cherry picked from commit 1691050)

# Conflicts:
#	ros2doctor/ros2doctor/api/__init__.py
@mergify mergify bot added the conflicts label Nov 27, 2025
@mergify
Copy link
Author

mergify bot commented Nov 27, 2025

Cherry-pick of 1691050 has failed:

On branch mergify/bp/kilted/pr-1117
Your branch is up to date with 'origin/kilted'.

You are currently cherry-picking commit 1691050.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   ros2cli/package.xml
	modified:   ros2cli/ros2cli/entry_points.py
	modified:   ros2doctor/package.xml
	modified:   ros2pkg/package.xml
	modified:   ros2pkg/ros2pkg/api/create.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   ros2doctor/ros2doctor/api/__init__.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request Nov 27, 2025
Merged
@ahcorde
Copy link
Contributor

ahcorde commented Nov 27, 2025

Pulls: #1119
Gist: https://gist.githubusercontent.com/ahcorde/311cbfbcb67552554acd1ecf3a2ef301/raw/c66bc731db023a3b4310f2de3fe41df1775b67d8/ros2.repos
BUILD args: --packages-above-and-dependencies ros2cli ros2doctor ros2pkg
TEST args: --packages-above ros2cli ros2doctor ros2pkg
ROS Distro: kilted
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17625

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
Fixed merge
bff0754 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde
Copy link
Contributor

ahcorde commented Dec 3, 2025

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
make linters happy
1f5133e 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde
Copy link
Contributor

ahcorde commented Dec 5, 2025

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
Copy link
Contributor

ahcorde commented Dec 9, 2025

Pulls: #1119
Gist: https://gist.githubusercontent.com/ahcorde/4063a5438a68d952e3a6972d8f3d195c/raw/c66bc731db023a3b4310f2de3fe41df1775b67d8/ros2.repos
BUILD args: --packages-above-and-dependencies ros2cli ros2doctor ros2pkg
TEST args: --packages-above ros2cli ros2doctor ros2pkg
ROS Distro: kilted
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17718

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit bf0eb36 into kilted Dec 9, 2025
3 checks passed
@ahcorde ahcorde deleted the mergify/bp/kilted/pr-1117 branch December 9, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees

No one assigned

Labels

conflicts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ahcorde @InvincibleRMC