[service introspection] generate service_event messages #700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 10, 2022
ihasdapie
force-pushed
the
service_introspection
branch
from
31c0e4c to
d5ea939
Compare
jacobperron
reviewed
Aug 16, 2022
Member
jacobperron
left a comment
jacobperron
left a comment
There was a problem hiding this comment.
I think this PR can be rebased on rolling now.
ivanpauno
reviewed
Sep 5, 2022
jacobperron
force-pushed
the
service_introspection
branch
from
9e0b981 to
9b67b48
Compare
Member
|
rebased on rolling |
jacobperron
reviewed
Oct 3, 2022
jacobperron
reviewed
Oct 3, 2022
jacobperron
force-pushed
the
service_introspection
branch
2 times, most recently
from
781943c to
8390962
Compare
ivanpauno
approved these changes
Nov 11, 2022
Member
ivanpauno
left a comment
ivanpauno
left a comment
There was a problem hiding this comment.
LGTM!
I have left some comments for myself to double check before merging.
ivanpauno
previously requested changes
Nov 11, 2022
Member
ivanpauno
left a comment
ivanpauno
left a comment
There was a problem hiding this comment.
same for typesupport introspection cpp
ivanpauno
dismissed
their stale review
cannot review anymore as new assignee
ivanpauno
requested review from
adityapande-1995,
methylDragon,
quarkytale and
sloretz
as code owners
Member
|
CI:
|
Member
|
There's a bug with actions, I have to double check what's going on |
Member
|
Hopefully got it right now:
|
Member
|
Member
|
windows error seems unrelated, though I don't see that happening in the nightlies .... There are also new linter failres, but those should be easy to fix ... |
Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
This was probably a bug introduced during a rebase. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
This allows users to pass interfaces in nested directories, e.g. test/srv/Foo.srv, instead of requiring them to be directly inside a 'srv' or 'action' directory relative to the cmake source directory. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
…on c/cpp Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
…esupports Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
…ture Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
…rt_tests Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
That is more correct, as this should not be a UUID. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
force-pushed
the
service_introspection
branch
from
0552fe4 to
01beada
Compare
mjcarroll
approved these changes
Jan 31, 2023
Contributor
|
CI for this is in ros2/ros2#1285 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of a prototype implementation for ros-infrastructure/rep#360 ros2/ros2#1285.
The rosidl generators are extended to generate a third message type for services, service events. Macro for generating interfaces in
rosidl_cmakeare also updated tofind_packageservice_msgs introduced in ros2/rcl_interfaces#143 and the new dependency onservice_msgsbyaction_msgs.Changes:
rosidl_service_type_support_tfor building service messages and to provide the publisher typesupport handle.This PR depends on #696
Service introspection: ros2/ros2#1285