Service introspection #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
jacobperron
force-pushed
the
service_introspection
branch
from
4eea5a5 to
c53940d
Compare
Member
|
rebased on rolling |
ivanpauno
approved these changes
Nov 10, 2022
Comment on lines
+125
to
+126
| @# Service request/response messages are included in the srv__struct | ||
| @[continue] |
Member
There was a problem hiding this comment.
we could use the same style as L128-129 to avoid confusions
mjcarroll
approved these changes
Jan 31, 2023
Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
Contributor
|
CI:
|
clalancette
force-pushed
the
service_introspection
branch
from
c53940d to
e5c848e
Compare
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Contributor
|
Another CI try with the latest style fixes:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of a prototype implementation for ros-infrastructure/rep#360 ros2/ros2#1285.
Changes: