Skip to content

Conversation

@bbengfort
Copy link
Contributor

@bbengfort bbengfort commented Oct 15, 2025

Scope of changes

Allows users to specify an auth url to authenticate with Quarterdeck rather than relying on the Endeavor proxy. This is a temporary fix for the 503 proxy issue in Endeavor but will also mean that we can directly access Quarterdeck methods (e.g. for users and api keys) in the future, so it's an important addition.

Fixes SC-35451

Type of change

  • new feature
  • bug fix
  • documentation
  • testing
  • technical debt
  • other (describe)

Acceptance criteria

Does this fix the authentication issue?

Definition of Done

  • I have manually tested the change running it locally (having rebuilt all containers) or via unit tests
  • I have added unit and/or integration tests that cover my changes
  • I have added new test fixtures as needed to support added tests
  • I have updated the dependencies list if necessary (including updating yarn.lock and/or go.sum)
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have notified the reviewer via Shortcut or Slack that this is ready for review

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.
  • Are there any TODOs in this PR that should be turned into stories?

Copilot AI review requested due to automatic review settings October 15, 2025 13:36
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for specifying a separate authentication endpoint to resolve 503 proxy issues with Endeavor. The change allows users to authenticate directly with Quarterdeck instead of relying on the Endeavor proxy.

  • Adds auth_url parameter to client configuration with environment variable fallback
  • Updates authentication methods to use the separate auth endpoint
  • Modifies the connect function to accept and pass through the auth_url parameter

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
guidelight/client.py Adds auth_url property, updates authentication methods to use separate endpoint
guidelight/init.py Updates connect function to accept auth_url parameter

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@bbengfort bbengfort merged commit 2ac3079 into main Oct 15, 2025
3 checks passed
@bbengfort bbengfort deleted the sc-35451 branch October 15, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants