-
Notifications
You must be signed in to change notification settings - Fork 9
Adding support for Client TLS #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mintsoft
wants to merge
8
commits into
rotdrop:master
Choose a base branch
from
mintsoft:client-tls
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I think this works but I've been unable to test as I can't get the JS in master to build at the moment and I've not had a chance to dig into what's going on: |
Author
|
Gave up with trying to fix the lint and commented it out of the build, but I have tested this with mTLS now and it does work as desired. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've recently migrated to using Mutual TLS for my setup, which broke the roundcube addon. Looking at the logs it's because when roundcube would be logging in, it's not using a TLS certificate so Apache is rejecting the connection.
The only solution I can see for this is to extend this addon to support using TLS auth with its own certificate.
Still a WIP but feedback sought throughout.