-
-
Notifications
You must be signed in to change notification settings - Fork 304
feat(gemini): add Gemini 3 Pro Preview low/high reasoning effort mode… #358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
feat(gemini): add Gemini 3 Pro Preview low/high reasoning effort mode… #358
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Summary of ChangesHello @nestharus, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces new Gemini 3 Pro Preview model variants that allow for explicit low or high reasoning effort. It also integrates the necessary functionality to automatically apply the corresponding Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for Gemini 3 Pro Preview's low and high reasoning effort modes by adding new model definitions and injecting the reasoning_effort parameter based on the model ID suffix. The implementation is mostly correct, but I've identified a critical bug in the new injectGemini3ReasoningEffort function where an error is ignored, potentially leading to corrupted request payloads. I've also included a medium-severity suggestion to address code duplication in the model definitions to improve maintainability.
4a0b6c0 to
23919f3
Compare
Add support for gemini-3-pro-preview-low and gemini-3-pro-preview-high model variants via suffix parsing and normalization. Changes: - Add ParseGemini3ReasoningEffortSuffix to parse -low/-high suffixes - Add Gemini3ReasoningEffortFromMetadata to read effort from metadata - Update NormalizeGeminiThinkingModel to handle reasoning effort first - Add injectGemini3ReasoningEffort to inject reasoning_effort into payload - Add IsGemini3Model utility function The -low and -high suffixes: 1. Get normalized to base model for routing 2. Store reasoning effort in metadata 3. Executor injects reasoning_effort into payload 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
23919f3 to
3f6220f
Compare
Add support for
gemini-3-pro-preview-lowandgemini-3-pro-preview-highmodel variants via suffix parsingand normalization.
-lowand-highsuffixes from Gemini 3 model namesreasoning_effortinto payload at executor levelgemini-3-pro-previewmodelHow it works
gemini-3-pro-preview-low→ normalized togemini-3-pro-previewwith{"gemini3_reasoning_effort": "low"}in metadatareasoning_effort: "low"into the payloadTest plan
gemini-3-pro-preview-lowrequest - uses ~143 reasoning tokensgemini-3-pro-preview-highrequest - uses ~271 reasoning tokensgemini-3-pro-previewmodel