Open
Conversation
There was a problem hiding this comment.
Code Review
This pull request implements streaming response aggregation for the CodeBuddy executor. Key changes include updating request translation to support streaming, adding required HTTP headers, and introducing the aggregateOpenAIChatCompletionStream function to merge stream chunks into a standard chat completion format. Review feedback identified a critical logic error where the translated payload was being incorrectly overwritten and suggested optimizing redundant JSON parsing during the stream aggregation process.
Comment on lines
+403
to
+421
| root := gjson.ParseBytes(payload) | ||
| if responseID == "" { | ||
| responseID = root.Get("id").String() | ||
| } | ||
| if model == "" { | ||
| model = root.Get("model").String() | ||
| } | ||
| if created == 0 { | ||
| created = root.Get("created").Int() | ||
| } | ||
| if serviceTier == "" { | ||
| serviceTier = root.Get("service_tier").String() | ||
| } | ||
| if systemFP == "" { | ||
| systemFP = root.Get("system_fingerprint").String() | ||
| } | ||
| if detail, ok := parseOpenAIStreamUsage(line); ok { | ||
| usageDetail = detail | ||
| } |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更说明
chat.completion.chunk聚合为单次非流式chat.completion响应