Fix Google OAuth invalid_client setup + improve desktop guidance#374
Fix Google OAuth invalid_client setup + improve desktop guidance#374liuxiaopai-ai wants to merge 2 commits intorowboatlabs:mainfrom
Conversation
|
@liuxiaopai-ai is attempting to deploy a commit to the RowBoat Labs Team on Vercel. A member of the Team first needs to authorize it. |
liuxiaopai-ai
changed the title
| if (reason !== 'new_flow_started') { | ||
| const provider = activeFlow.provider; | ||
| const error = (reason === 'timed_out' && provider === 'google') | ||
| ? 'Timed out waiting for Google OAuth to finish. If your browser showed “Error 401: invalid_client”, double-check that you entered the OAuth Client ID (it should end with .apps.googleusercontent.com) and that it was created as a Desktop app OAuth client. Setup guide: https://github.com/rowboatlabs/rowboat/blob/main/google-setup.md' |
There was a problem hiding this comment.
I'd rather put this guidance on the input modal where the user provides their key instead of a long-winded error-message.
| <DialogTitle>Enter Google Client ID</DialogTitle> | ||
| <DialogDescription> | ||
| This app does not store the client ID. You will be prompted each session. | ||
| Paste the OAuth Client ID (it should end with .apps.googleusercontent.com). Do not paste the client secret. This app does not store it, so you will be prompted each session. |
There was a problem hiding this comment.
We should remove this part: This app does not store it...., as that is no longer correct. The app does store it and persist it across sessions.
| Select: | ||
|
|
||
| **Universal Windows Platform (UWP)** | ||
| **Desktop app** |
There was a problem hiding this comment.
Did you actually test this in GCP? Desktop app client did not work in our testing, whereas UWP did. Thats why we are recommending this.
| - Click **Create** | ||
|
|
||
|  | ||
| > Note: Rowboat Desktop uses a local redirect URI during OAuth: |
There was a problem hiding this comment.
Not sure why the end-user would care about this information.
2 participants
Fixes #353.
What changed
Tests