Skip to content

update readme on how to build jet#129

Open
metaclips wants to merge 1 commit intorpcpool:mainfrom
metaclips:metaclips/build_docs
Open

update readme on how to build jet#129
metaclips wants to merge 1 commit intorpcpool:mainfrom
metaclips:metaclips/build_docs

Conversation

@metaclips
Copy link

Minor update to readme on how to build Jet

Copilot AI review requested due to automatic review settings February 9, 2026 07:40
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the root README build instructions for Yellowstone Jet so users can build the intended binary rather than building the whole workspace by default.

Changes:

  • Switch README build command to target the jet binary explicitly (cargo build --bin jet --release).
  • Add a note about the expected output path for the built binary.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@metaclips metaclips force-pushed the metaclips/build_docs branch 2 times, most recently from 04f7c88 to c1f1ae6 Compare February 9, 2026 08:04
@metaclips metaclips requested a review from Copilot February 9, 2026 08:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@leafaar leafaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, could you apply/verify the suggestions I made?

@metaclips metaclips force-pushed the metaclips/build_docs branch from c1f1ae6 to cef41e6 Compare February 10, 2026 03:21
@metaclips
Copy link
Author

Thanks for the contribution, could you apply/verify the suggestions I made?

Thanks @leafaar I implemented your suggestions.

While reviewing the systemd configuration, I noticed that it still references the yellowstone-jet binary instead of jet. This could cause issues for first-time users.

Should we rename ./apps/jet/src/bin/jet.rs to yellowstone-jet.rs so the built binary matches the configuration, or should we standardize on the jet binary name across the project?

@leafaar
Copy link
Contributor

leafaar commented Feb 10, 2026

need to tag @ananthb here for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants