Open
Conversation
joshleecreates
requested changes
Sep 21, 2018
src/components/CreatureForm.jsx
Outdated
| {this.state.counters.map((counter, index) => | ||
| <div key={index} className="creature-form__counter"> | ||
| <DragHandle><FontAwesomeIcon icon={faSort} /></DragHandle> | ||
| <DragHandle><FontAwesomeIcon icon={faSort} cursor="pointer" /></DragHandle> |
Collaborator
There was a problem hiding this comment.
This should be in CSS, not here.
src/components/CreatureForm.jsx
Outdated
| tabIndex="-1" | ||
| > | ||
| <FontAwesomeIcon icon={faTrashAlt} /> | ||
| <FontAwesomeIcon icon={faTrashAlt} cursor="pointer" /> |
| justify-content: center; | ||
| font-size: 24px; | ||
| min-width: 50px; | ||
| max-width: 97%; |
Collaborator
There was a problem hiding this comment.
Don't do this. Use 100% and an appropriate box-sizing model.
| display: flex; | ||
| justify-content: flex-start; | ||
|
|
||
| & { |
Collaborator
Author
|
@joshleecreates ready for re-review |
Necessary to control the input value via state rather than props
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the mobile device usability. Most of the CSS added in this PR is going to be refactored when we remove .
There is more polishing to be done but this is a good start. 🐳
TODO: fix the bug with editing counters on mobile.