python only solution to read and parse dbus#6
Open
mkoreneff wants to merge 5 commits intorpieja:masterfrom
Open
python only solution to read and parse dbus#6mkoreneff wants to merge 5 commits intorpieja:masterfrom
mkoreneff wants to merge 5 commits intorpieja:masterfrom
Conversation
makes the awk and shell scripts redundant
Owner
|
Thanks for your activity! I'll check out changes and merge in a few days once i get some free time. |
Author
|
There is an issue with spotifyd and reading from the dbus when no song is playing. I'm not sure if the same issue is present when using the native player. Spotifyd/spotifyd#337 |
|
The removal of the awk stuff also fixes an issue I had where a song title was cut off if But when using the Spotify package in the AUR (not spotifyd) and it isn't open, it crashes i3bar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this update we make the shell and awk scripts redundant and parse everything in python.