Skip to content

Conversation

@bunnylushington
Copy link

Hi -- I ran into a small issue while building up a release where the fakerl deps were not declared in its app file. (I use fakerl to generate data for automated post-release testing, which is why it's part of the release ... I can imagine wondering.) Anyhow, here's a quick PR with the update. Note that this change is not compatible if projects bundling fakerl declared fakerl's deps in their own app file (relx, at least, complains that duplication applications are included).

Anyhow, thanks again for the library, it's been a godsend!

@rpip
Copy link
Owner

rpip commented Aug 5, 2015

Thanks, @kevinmontuori!

It's generally recommended to use the included_applications feature only when necessary. The use case you describe seems like a good one, but I think you can include the dependencies in the release without declaring them as included_applications. I think the right thing to do here is to add them to the applications. Please see this http://learnyousomeerlang.com/the-count-of-applications#included-applications and https://github.com/erlware/relx/wiki/configuration#priority-application-loading

I'll add them right away.

@rpip
Copy link
Owner

rpip commented Aug 5, 2015

Added the dependencies to the applications.

Please try again and let me know if that solves the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants