Umd folder #1704
Open
Umd folder #1704
+43
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'real' playback, there should be a mount or a keyboard event which will serve to unfreeze the page. Also add other non-user events to the list (we really should have an `isUserEvent` function)
🦋 Changeset detectedLatest commit: 65dd85e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…th a plain `.js` instead of `.cjs` extension, as the latter won't be served with the correct mime type by jsdelivr - rrweb-io#1687 (just rename `.cjs` to `.js`) was rejected due to the the 'dual package hazard' [1], and produces a warning when run through publint.dev (which was the original motivation for changing to \.cjs) - jsdelivr won't be serving `.cjs` with the correct mime type: jsdelivr/jsdelivr#18584 [1] https://nodejs.org/en/learn/modules/publishing-a-package#the-dual-package-hazard
…will be available after the changes in this PR
This was referenced Jun 26, 2025
Juice10
reviewed
Sep 5, 2025
Juice10
reviewed
Sep 5, 2025
|
I just realized this is missing changes to package.json file which include the umd files in npm packages (otherwise this won't be saved by jsdelivr: it needs to be this instead: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new
umdfolder alongsidedistfor output of UMD files with a plain.jsinstead of.cjsextension, as the latter won't be served with the correct mime type by jsdelivr.umd.cjsdist files to.umd.jsto satisfy jsdelivr #1687 (just rename.cjsto.js) was rejected due to the the dual package hazard, and produces a warning when run through publint.dev (which was the original motivation for changing to .cjs).cjswith the correct mime type: Browsers refuse scripts withapplication/nodemime type jsdelivr/jsdelivr#18584