reformat problematic plotting#187
Conversation
kmdalton
left a comment
kmdalton
left a comment
There was a problem hiding this comment.
This is a good idea, but we should think a bit about what we want to do. There is a danger that as we go down this path of adding workarounds, we end up supporting the entire matplotlib API via the command line parser. I want to avoid that. This is one reason I provide the --show flag so users can tweak the plot interactively using the mpl GUI. Regardless, it's a good idea to have sensible defaults at the CLI if possible. I'm happy to greenlight some solution based on passing image dimensions to the parser. Before I merge this, I would just request that we make the --width and --height arguments consistently implemented across the stats submodule. I think we can do this by adding them to the BaseParser and double checking that plt.figure is called using the parser.height and parser.width in each of the subprograms.
careless/stats/ccpred.py
Outdated
| help="Pool all prediction mtz files into a single calculation rather than treating each file individually.", | ||
| ) | ||
|
|
||
| self.add_argument( |
There was a problem hiding this comment.
If arguments like this are to be added, I would request that they are added in careless/states/parser.py:BaseParser and then propagated to all the stats submodules.
…ts to take height and width args
|
See commit above, in reply to change request. I'll also push a change to careless-examples reflecting use of the |
|
alright, regarding the previous comment, see rs-station/careless-examples@b7b887d |
2 participants
forced the legends above plots for
ccpred.pyand image_cc.py and changed default height and width of each plot. Added height and width arguments forccpred.py. Forced legends to the upper left forrsplit.py.