Skip to content

scaling function guardrails#144

Open
tjlane wants to merge 3 commits intomainfrom
tjlane/scalefix
Open

scaling function guardrails#144
tjlane wants to merge 3 commits intomainfrom
tjlane/scalefix

Conversation

@tjlane
Copy link
Member

@tjlane tjlane commented Jan 31, 2026

If crazy data are passed to the scaling function, it can produce np.infs and crash mysteriously. This PR at least catches that and adds a warning message for the user.

Ideally we'd catch outliers and data issues upstream. I feel that's important but can come in a second PR (or multiple PRs). It requires research.

@tjlane tjlane changed the title [WIP] scaling function guardrails scaling function guardrails Feb 1, 2026
@tjlane tjlane marked this pull request as ready for review February 1, 2026 19:42
@tjlane tjlane self-assigned this Feb 1, 2026
@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.60%. Comparing base (c49b519) to head (c8f6bb1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
+ Coverage   95.57%   95.60%   +0.02%     
==========================================
  Files          16       16              
  Lines         995     1000       +5     
==========================================
+ Hits          951      956       +5     
  Misses         44       44              
Flag Coverage Δ
unittests 95.60% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants