Add compatibility for totp codes with different intervals#7
Open
gergesh wants to merge 5 commits intorsc:masterfrom
Open
Add compatibility for totp codes with different intervals#7gergesh wants to merge 5 commits intorsc:masterfrom
gergesh wants to merge 5 commits intorsc:masterfrom
Conversation
Collaborator
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Author
|
Signed. |
Collaborator
|
CLAs look good, thanks! |
dmitshur
reviewed
Feb 10, 2018
| raw []byte | ||
| digits int | ||
| offset int // offset of counter | ||
| interval int // interval of generation |
|
@gergesh could you adapt to https://github.com/xplshn/2fa? I'm going to maintain my fork even if Russ doesn't merge its changes, and its going to be available via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From my testing, everything seems alright but it could be that I haven't tested everything.
The downside is that the ~/.2fa file format has changed a bit, so you'll have to (very slightly) modify it to migrate to the new version.