Conversation
unmaintained). I also increased the python recursive limit, because it was necessary to work correctly for one of my documents. I also removed the initialize() statement, because this is not needed (anymore?).
|
Thanks! I didn't know about PyPDF2. It looks like PyPDF2 is mostly API-compatible with pyPdf. What I'd Also, the README should be updated with the new dependency information. Re the initialize() call: Maybe there's no point anymore, but I was The recursion issue is odd. I don't think we're doing anything Thanks again! |
prsannots/generic.py
Outdated
There was a problem hiding this comment.
I don't think this import is needed. Perhaps it's left over from diagnostics you were doing?
I have also removed the import of the write statements.
|
Okay, in my latest commit I have removed the recursion statement and the diagnostics issue you pointed out in your earlier message. This should thus only contain the upgrade to PyPDF2. I have kept the removal of the .initialize() statement, because the code just crashes on my machine (i.e. with a newer version of pdfminer, currently at 20140328). I don't know if I should create a new pull request. Or can you also import my commits from here? (I'm new to github). |
|
I actually just got a DPT-S1, which is far superior in annotating pdf-files. Therefore, I have no further need for the prsannots program, and thus I would not be inclined to be involved in writing a helper function. |
|
For one of the documents, I had trouble with the recursion issue: the code crashed in a pdfminer statement (I don't have the details anymore). It said the recursion limit had been exceeded, so I just increased it. |
I modified the code to use PyPDF2 instead of pypdf (which seems to be unmaintained). This was necessary to make the code run on my Gentoo system.
I thought you could be interested in this code.
Further minor modifications are: