This repository was archived by the owner on Oct 12, 2023. It is now read-only.
refactor: uses lowercased addresses to interact with the server #674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itofarina
changed the title
- and process them as lowercased as well
itofarina
force-pushed
the
refactor/lowercaseAddresses
branch
from
ae83631 to
75e778a
Compare
itofarina
commented
May 12, 2021
| * @param {string} address | ||
| * @param {string} network | ||
| */ | ||
| toChecksumAddressIfNeeded(address, network) { |
Contributor
Author
There was a problem hiding this comment.
This function should receive the networkId that would be used to apply checksum format
| transactionState, transactionId, amount, dateTime, memo, confirmations, title, stateIcon, isRefreshing, from, to, chain, | ||
| } = this.state; | ||
|
|
||
| const fromChecksum = common.toChecksumAddressIfNeeded(from, chain); |
Contributor
Author
There was a problem hiding this comment.
We only have the chain name here, would be best to get and send networkId for checksum format check
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.