FIX: non-latin headers#13
Open
asakasinsky wants to merge 1 commit intorstacruz:gh-pagesfrom
asakasinsky:gh-pages
Open
FIX: non-latin headers#13asakasinsky wants to merge 1 commit intorstacruz:gh-pagesfrom asakasinsky:gh-pages
asakasinsky wants to merge 1 commit intorstacruz:gh-pagesfrom
asakasinsky:gh-pages
Conversation
if the "text" value passed to "slugify" function consist only non-latin characters (cyrillic, for example), regular expression match === null. And we get an error on "join('-')".
|
I have the same problem |
|
I'm having this problem now. I see that a solution has been offered, but I'm not sure how to implement this solution locally (since it doesn't seem to have been updated in the code yet)? |
|
This solution fixes the page display but menu in sidebar still does not work correctly. |
Owner
|
Thanks, I think the better solution is to use |
Open
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
if the "text" value passed to "slugify" function consist only non-latin characters (cyrillic, for example), regular expression match === null. And we get an error on "join('-')".
Solution:
I assigned to match result (if match===null) a timestamp. This solution a little bad for the semantics, but completely solve the problem