Add Unit Test #75
Open
Add Unit Test #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename workflow file for PHPCS, for better clarity
Setup PHPUnit testing
feature/GH-66 : Add PHPCS ruleset
Update admin class test to use utility methods
Initialize AMP_Admanager class
Add tests for class-admin.php and class-shortcode.php
Test case for AMP_AdManager class
Update Readme with Contributing guideline and Add tests folder to skip_folders list
Add docblock description for test functions
sagarnasit
requested changes
Mar 27, 2020
Member
sagarnasit
left a comment
sagarnasit
left a comment
There was a problem hiding this comment.
@deepaklalwani97 Added a couple of feedbacks. Please resolve that.
Member
|
@sagarnasit I have addressed all the feedbacks. |
sagarnasit
approved these changes
Apr 2, 2020
Member
sagarnasit
left a comment
sagarnasit
left a comment
There was a problem hiding this comment.
@deepaklalwani97 Please remove the duplicate assertion I mentioned. I'm approving this PR. Ready to go after this change.
Comment on lines
421
to
422
| $this->assertNotEmpty( $output ); | ||
| $this->assertNotEmpty( $output ); |
Member
There was a problem hiding this comment.
Remove duplicate assertion from here.
Fix issue with custom targeting attributes in get_ads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#60