Fix/phpcs fixes #289
Fix/phpcs fixes #289
Conversation
Creation of dynamic property RetranscodeMedia::$capability is deprecated in /var/www/htdocs/wp-content/plugins/transcoder/admin/rt-retranscode-admin.php on line 82
rtBot
left a comment
rtBot
left a comment
There was a problem hiding this comment.
Code analysis identified issues
action-phpcs-code-review has identified potential problems in this pull request during automated scanning. We recommend reviewing the issues noted and that they are resolved.
phpcs scanning turned up:
🚫 4 errors
Powered by rtCamp's GitHub Actions Library
| @@ -1 +1 @@ | |||
| <?php //Silence is golden | |||
There was a problem hiding this comment.
🚫 Error: You must use "/**" style comments for a file comment (Squiz.Commenting.FileComment.WrongStyle).
| @@ -1 +1 @@ | |||
| <?php //Silence is golden | |||
There was a problem hiding this comment.
🚫 Error: Inline comments must end in full-stops, exclamation marks, or question marks (Squiz.Commenting.InlineComment.InvalidEndChar).
| */ | ||
| public $menu_id; | ||
|
|
||
| /** |
There was a problem hiding this comment.
🚫 Error: Tabs must be used to indent lines; spaces are not allowed (Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed).
| public $menu_id; | ||
|
|
||
| /** | ||
| * capability of user required to retranscode. |
There was a problem hiding this comment.
🚫 Error: Doc comment short description must start with a capital letter (Generic.Commenting.DocComment.ShortNotCapital).
| } | ||
|
|
||
| // Allow people to change what capability is required to use this feature. | ||
| $this->capability = apply_filters( 'retranscode_media_cap', 'manage_options' ); |
There was a problem hiding this comment.
I think we should document this in the Readme.MD
Vedant-Gandhi
left a comment
Vedant-Gandhi
left a comment
There was a problem hiding this comment.
We need to fix the rtBot errors.
Creation of dynamic property RetranscodeMedia::$capability is deprecated in /var/www/htdocs/wp-content/plugins/transcoder/admin/rt-retranscode-admin.php on line 82