Conversation
Author
|
Any news about this? I know the tests are failing on some job, but I'm not sure why |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using this module with webpack is impossible. First the module entrypoint is index.js but it should be, instead, the result of the build. Using the module like this, on development, it installs and requires modules which does not work when the target is "browser".
This PR adds a
prepublishscript to generate the dist folder everytime the packet is published on npm.Then it expose dist/quickconnect.js. It doesn't expose the minified version because this can be done later by the application which uses it.