Skip to content

Add tests for the calendar date spectrum #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add tests for the calendar date spectrum #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion elm.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@
"elm/time": "1.0.0 <= v < 2.0.0"
},
"test-dependencies": {
"elm-explorations/test": "1.0.0 <= v < 2.0.0"
"elm-explorations/test": "2.0.0 <= v < 3.0.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required by elm-test.

}
}
19 changes: 18 additions & 1 deletion tests/Example.elm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ module Example exposing (knownValues, reflexive)
import Expect
import Fuzz
import Iso8601
import Json.Decode exposing (decodeString, errorToString)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import reordering change from elm-format.

import Test exposing (..)
import Time
import Json.Decode exposing (decodeString, errorToString)


knownValues : Test
Expand Down Expand Up @@ -99,11 +99,28 @@ knownValues =
\_ ->
Iso8601.toTime "2019-05-30T06:30"
|> Expect.equal (Ok (Time.millisToPosix 1559197800000))
, test "toTime supports yyyymmddThh:mm truncated representation format" <|
\_ ->
Iso8601.toTime "20190530T06:30"
|> Expect.equal (Ok (Time.millisToPosix 1559197800000))
, test "toTime supports yyyymmdd truncated representation format" <|
\_ ->
Iso8601.toTime "2019-05-30"
|> Expect.equal (Ok (Time.millisToPosix 1559174400000))
, test "toTime does not support the deprecated yyyymm truncated representation format" <|
\_ ->
Iso8601.toTime "201905"
|> Expect.err
, test "toTime does not support the deprecated yyyy truncated representation format" <|
\_ ->
Iso8601.toTime "2019"
|> Expect.err
, test "decoder returns clearer error for dead ends" <|
\_ ->
case decodeString Iso8601.decoder "2010-09-31T14:29:25.01235Z" of
Err error ->
Expect.notEqual (errorToString error) "TODO deadEndsToString"

Ok _ ->
Expect.fail "Should fail on dead ends"
]
Expand Down