Skip to content

correcting documentation for validators that return a context #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
taj wants to merge 1 commit into
base: master
Choose a base branch
from
Open

correcting documentation for validators that return a context #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ case validate someValidator someSubject of
For example:

```elm
import Validate exposing (ifBlank, ifNotInt, validate)
import Validate exposing (ifBlank, ifNotInt, ifEmptyList, validate)


type alias Model =
Expand All @@ -28,7 +28,7 @@ modelValidator =
Validate.all
[ ifBlank .name "Please enter a name."
, ifBlank .email "Please enter an email address."
, ifNotInt .age "Age must be a whole number."
, ifNotInt .age (\_ -> ("Age must be a whole number."))
, ifEmptyList .selections "Please select at least one."
]

Expand Down Expand Up @@ -56,7 +56,7 @@ modelValidator =
Validate.all
[ ifBlank .name ( Name, "Please enter a name." )
, ifBlank .email ( Email, "Please enter an email address." )
, ifNotInt .age ( Age, "Age must be a whole number." )
, ifNotInt .age (\value -> ( Age, value ++ "is not a whole number." ))
, ifEmptyList .selections ( Selections, "Please select at least one." )
]

Expand Down
4 changes: 2 additions & 2 deletions examples/SignupForm.elm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ modelValidator =
[ ifBlank .name ( Name, "Please enter a name." )
, Validate.firstError
[ ifBlank .email ( Email, "Please enter an email address." )
, ifInvalidEmail .email ( Email, "This is not a valid email address." )
, ifInvalidEmail .email (\value -> ( Email, value ++ " is not a valid email address." ))
]
, ifNotInt .age ( Age, "Age must be a whole number." )
, ifNotInt .age (\_ -> ( Age, "Age must be a whole number." ))
, ifEmptyList .selections ( Selections, "Please select at least one." )
]

Expand Down
12 changes: 6 additions & 6 deletions src/Validate.elm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ module Validate exposing
[ ifBlank .email "Please enter an email address."
, ifInvalidEmail .email "This is not a valid email address."
]
, ifNotInt .age "Age must be a whole number."
, ifNotInt .age (\_ -> "Age must be a whole number.")
]

validate modelValidator { name = "Sam", email = "blah", age = "abc" }
Expand Down Expand Up @@ -109,7 +109,7 @@ subject.
Validate.all
[ ifBlank .name ( Name, "Please enter a name." )
, ifBlank .email ( Email, "Please enter an email address." )
, ifNotInt .age ( Age, "Age must be a whole number." )
, ifNotInt .age (\_ -> ( Age, "Age must be a whole number." ))
]

validate modelValidator { name = "Sam", email = "", age = "abc" }
Expand Down Expand Up @@ -333,7 +333,7 @@ error lists.
Validate.all
[ ifBlank .name "Please enter a name."
, ifBlank .email "Please enter an email address."
, ifNotInt .age "Age must be a whole number."
, ifNotInt .age (\_ -> "Age must be a whole number.")
]

-}
Expand Down Expand Up @@ -364,10 +364,10 @@ and returning it. If no errors are encountered, return `Nothing`.
modelValidator =
Validate.all
[ Validate.firstError
[ ifBlank .email "Please enter an email address."
, ifInvalidEmail .email "This is not a valid email address."
[ ifBlank .email (\_ -> "Please enter an email address.")
, ifInvalidEmail .email (\_ -> "This is not a valid email address.")
]
, ifNotInt .age "Age must be a whole number."
, ifNotInt .age (\_ -> "Age must be a whole number.")
]


Expand Down